Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SampleDataUtil #67

Merged
merged 2 commits into from Oct 21, 2019
Merged

Fix SampleDataUtil #67

merged 2 commits into from Oct 21, 2019

Conversation

jonchan51
Copy link

@jonchan51 jonchan51 commented Oct 18, 2019 •
edited

SampleDataUtil could not access the images in the Resource folder.

This is resolved by copying the image out via an InputStream, then adding them to Weme.

Closes #45

@jonchan51 jonchan51 merged commit e282f60 into master Oct 21, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 23, 2019
Open
23 tasks
@jonchan51 jonchan51 deleted the jon/fix-sample-data branch October 27, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gary-lgy gary-lgy gary-lgy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample memes not included in jar file
2 participants
@jonchan51 @gary-lgy