Tags collation #76
Merged
Tags collation #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchan51
requested changes
Oct 23, 2019
BillChee123
reviewed
Oct 24, 2019
jonchan51
requested changes
Oct 25, 2019
|
|
||
| //============= Tag Data ==================================== | ||
|
|
||
| List<TagWithCount> getTagsWithCountList(ObservableList<Meme> memeList); |
There was a problem hiding this comment.
Suggested change
| List<TagWithCount> getTagsWithCountList(ObservableList<Meme> memeList); | |
| List<TagWithCount> getTagsWithCountList(List<Meme> memeList); |
| /** | ||
| * Get {@code TagWithCount} in PriorityQueue from a {@code ReadOnlyMemeBook}. | ||
| */ | ||
| public PriorityQueue<TagWithCount> getTagsInOrderOfCounts(ObservableList<Meme> memeList) { |
There was a problem hiding this comment.
Suggested change
| public PriorityQueue<TagWithCount> getTagsInOrderOfCounts(ObservableList<Meme> memeList) { | |
| public PriorityQueue<TagWithCount> getTagsInOrderOfCounts(List<Meme> memeList) { |
update comments accordingly
There was a problem hiding this comment.
The method takes in an ObservableList of Memes.
There was a problem hiding this comment.
Was thinking could just make it List instead since it doesn't necessarily have to be an observable list.
jonchan51
approved these changes
Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81 Add tag collation feature and a visual view in the form of PieChart.
Build a TagManager that parses a given MemeBook for the tags.
Adds a PieChart display of tags in a given MemeBook.