Changes to AboutUs.adoc and ContactUs.adoc #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemented methods.
…low Joshua's implementations.
# Conflicts: # build.gradle # docs/DeveloperGuide.adoc # docs/UserGuide.adoc
# Conflicts: # build.gradle # docs/DeveloperGuide.adoc
(cherry picked from commit cef6975)
# Conflicts: # src/main/java/seedu/address/logic/commands/editcommand/EditParticipantCommand.java
hcwong
pushed a commit
that referenced
this pull request
Oct 3, 2019
* Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Merge from upstream * Updated code to use Model#updateParticipant's return value. * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Imported Entities and other objects. * Updated AboutUs.adoc and ContactUs.adoc
34 tasks
john0227
added a commit
that referenced
this pull request
Nov 9, 2019
* Merge from upstream * Updated code to use Model#updateParticipant's return value. * Change Exception and UI class * Revert "Change Exception and UI class" (#16) This reverts commit 6e60a08. * Final changes to Feat/change exception class (#17) * Exception interface updates * Exception interface updates v1.1 * add parenthesis * Update DataConversionException.java * Update ParseException.java * Update DuplicateEntityException.java * Update Messages.java * Implement Model public methods (#7) * Implemented Entity abstract class * Add EntityList Interface * Add method to check for existence * Refactor EntityListInterface * Demo flow of how controller will call model via modelManager * Add team object * Create mentor class * Add issue type * Add the 4 lists. Now they are fairly repetitive, but do not want to prematurely optimize * Modify the Model API to reflect latest changes * Rename ID to Id and expose viewMinimal and viewDetailed methods * Add equals, toString, hash for all * Add line * Refactor/model api (#19) * Move all the CRUD methods from EntityList to ModelManager * Remove the override methods from the various EntityLists as they are now superflous * Remove circular references from entity objects * Created ReadableEntityList to abstract and implemented Participant methods * Implement API for all 4 entities. Pending only saving and load of model * Standardize all entities to have only 1 constructor as per Brian's comment * Make model throw AlfredRuntimeException * Rename package to use lowercase * Uncomment old person type methods to reduce errors * Morph storage (#18) * Update build.gradle file (minor changes) * Complete set-up for project (as per the Developer Guide) * Update README.adoc with Travis CI build status * Update some files to ensure that ./config/travis/run-checks.sh runs fine * Create the 4 different ListStorages. Create AlfredStorage. Create AlfredStorageManager (halfway done). * Creation of all necessary Storage classes (with the exception of the TeamListStorage handler classes) * Added Storage classes for TeamList * Fix bracket issue * Update Storage classes with appropriate JSON adaptation * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Implemented Participant Commands (#14) * Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Updated EditParticipantCommand Updated code to use return value of editParticipant() * Feat/validate objects (#15) * Added object validation * Edited code after review * Imported Entities and other objects. * Imported Entities and other objects (#2) * Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Merge from upstream * Updated code to use Model#updateParticipant's return value. * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Imported Entities and other objects. * Updated AboutUs.adoc and ContactUs.adoc * Update user guide (#26) * Update build.gradle file (minor changes) * Complete set-up for project (as per the Developer Guide) * Update README.adoc with Travis CI build status * Update some files to ensure that ./config/travis/run-checks.sh runs fine * Create the 4 different ListStorages. Create AlfredStorage. Create AlfredStorageManager (halfway done). * Creation of all necessary Storage classes (with the exception of the TeamListStorage handler classes) * Added Storage classes for TeamList * Fix bracket issue * Update Storage classes with appropriate JSON adaptation * Update User Guide * Update README.adoc * Changes to AboutUs.adoc and ContactUs.adoc (#29) * Made changes to fit team's scope. * Added AddCommands and DeleteCommands. * Added Edit Commands * Added List and View commands. * Corrected repoUrl * Made changes to follow Joshua's implementations. Contains vaguely-implemented methods. * Changed parameters from EntityList to Model. Made some changes to follow Joshua's implementations. * Moved ENTITY_TYPE to a static constant stored in CliSyntax. * Updated code to use viewMinimal() and viewDetailed(). * Minor changes * Implemented potential ways of executing each Participant command. * Merge from upstream * Updated code to use Model#updateParticipant's return value. * Removed Commands associated with Issues. * Removed Commands associated with Issues. (cherry picked from commit cef6975) * Imported Entities and other objects. * Updated AboutUs.adoc and ContactUs.adoc * Update UserGuide Introduction and Quickstart * Update UserGuide Section 4 * Move generate id to readable entityList so that controller and parser can call it (#31) * Alfred Add Command Parsers (#32) * Add Alfred-specific parser classes. * Modify prefixes. * Implement Add Command Parsers. * Made changes to teammate names. * Made changes to teammate names. (cherry picked from commit 7c8d00a) * Fix Storage Compilation Errors (#42) * Update build.gradle file (minor changes) * Complete set-up for project (as per the Developer Guide) * Update README.adoc with Travis CI build status * Update some files to ensure that ./config/travis/run-checks.sh runs fine * Create the 4 different ListStorages. Create AlfredStorage. Create AlfredStorageManager (halfway done). * Creation of all necessary Storage classes (with the exception of the TeamListStorage handler classes) * Added Storage classes for TeamList * Fix bracket issue * Update Storage classes with appropriate JSON adaptation * Update User Guide * Fixed all compilation problems * Alfred Delete Command Parser (#33) * Add Alfred-specific parser classes. * Modify prefixes. * Implement Add Command Parsers. * Implement Alfed delete command parsers. * Standardise command line syntax. * Revert "Alfred Delete Command Parser (#33)" (#43) This reverts commit 2da432d. * Update gitignore to ignore binary files (#44) * Fix compileTestJava (#45) * Update build.gradle file (minor changes) * Complete set-up for project (as per the Developer Guide) * Update README.adoc with Travis CI build status * Update some files to ensure that ./config/travis/run-checks.sh runs fine * Create the 4 different ListStorages. Create AlfredStorage. Create AlfredStorageManager (halfway done). * Creation of all necessary Storage classes (with the exception of the TeamListStorage handler classes) * Added Storage classes for TeamList * Fix bracket issue * Update Storage classes with appropriate JSON adaptation * Update User Guide * Fixed all compilation problems * Stop-gap fix for compileTestJava * Stop-gap measures to fix compileTestJava while fixing codebase * Fix add participant parser (#47) * Changed code to follow checkstyle 8.1 * Checkstyle: Commands and Parsers (#51) * Changed code to follow checkstyle * Checkstyle EntityList (#53) * Updated checkstyle * Checkstyle: SubjectName.java (#54) * Feat/checkstyle (#55) * Feat/checkstyle (#56) * Implement Basic Storage Tests and Fix Compile Errors (#57) * Update build.gradle file (minor changes) * Complete set-up for project (as per the Developer Guide) * Update README.adoc with Travis CI build status * Update some files to ensure that ./config/travis/run-checks.sh runs fine * Create the 4 different ListStorages. Create AlfredStorage. Create AlfredStorageManager (halfway done). * Creation of all necessary Storage classes (with the exception of the TeamListStorage handler classes) * Added Storage classes for TeamList * Fix bracket issue * Update Storage classes with appropriate JSON adaptation * Update User Guide * Fixed all compilation problems * Stop-gap fix for compileTestJava * Stop-gap measures to fix compileTestJava while fixing codebase * Ensure that ParticipantList can be saved and read from file * Remove all dependencies on Issues and IssueList for Storage * Create TypicalMentors.java file * Update SubjectName enum values * Update TypicalMentors.java * Fix compileTestJava compilation errors * Fix remaining checkstyle errors (#58) * Modify add command parsers to handle missing arguments. * Fix checkstyle errors. * Finished implementation of Commands for Team and Mentor * Changed code to follow checkstyle * Placeholders for each team member's adoc * Edit add parser arguments to make them consistent. * Rename addressbookparser to AlfredParser. * Edited code to reflect feedback * Added COMMAND_USAGE to all commands * Possible method to add participant/mentor to teams * Implemented test for AddParticipantCommand and StringUtil class * Fixed checkstyle for tests * Fixed checkstyle issues * Fixed checkstyle issues (cherry picked from commit 6dce664) * Implemented LoadCommand * Implemented ExportCommand * Fixed issues with Export and Load Command * Updated ListCommands * Implemented test for AddParticipantCommand and StringUtil class * Fixed checkstyle for tests * Fixed issues with AddParticipantCommandTest * Implemented AddCommandTests for all Entities * Implemented DeleteCommandTest for all entities and repackaged tests * Implemented ListCommandTests for all entities * Implemented ViewCommandTests for all Entities * Implemented test for AddParticipantCommand and StringUtil class * Fixed checkstyle for tests * Implemented test for AddParticipantCommand and StringUtil class * Fixed issues with AddParticipantCommandTest * Implemented AddCommandTests for all Entities * Implemented DeleteCommandTest for all entities and repackaged tests * Implemented ListCommandTests for all entities * Implemented ViewCommandTests for all Entities * Implemented EditCommandTests and EditDescriptorTests for all entities and updated other tests * Removed potential issue of travis failure * Implemented ExportCommand for all entities and updated the contains() method in all implementations of EntityList * Implemented Parsers for Export and Load Commands * Implemented LoadCommand * Implemented ExportCommand * Fixed issues with Export and Load Command * Implemented ExportCommand for all entities and updated the contains() method in all implementations of EntityList * Implemented Parsers for Export and Load Commands * Updated Export and Load Commands * Fixed checkstyle issues and refactored LoadCommand * Updated validation of SubjectName and ProjectType and other minor updates * Fixed checkstyle issue * Implemented LoadCommand * Implemented ExportCommand * Fixed issues with Export and Load Command * Implemented ExportCommand for all entities and updated the contains() method in all implementations of EntityList * Implemented Parsers for Export and Load Commands * Implemented LoadCommand * Implemented ExportCommand * Fixed issues with Export and Load Command * Implemented ExportCommand for all entities and updated the contains() method in all implementations of EntityList * Implemented Parsers for Export and Load Commands * Updated Export and Load Commands * Fixed checkstyle issues and refactored LoadCommand * FIxed error * Implemented tests for CsvUtil * Implemented tests for Id * Implemented tests for Error and ErrorTracker * Implemented tests for LoadCommand * Fixed checkstyle issues * Implemented tests for LoadCommandParser * Implemented tests for ExportCommandParser * Implemented tests for ExportCommand * Implemented tests for all subclasses of ExportCommands * Fixed checkstyle issues * Updated CommandException * Updated LoadCommand and ExportCommand to allow loading/exporting of Participants and Mentors of Teams through csv * Updated tests for Load and Export Commands * Fixed checkstyle issues * Fixed travis issues * Fixed potential Travis issues * Fixed travis * Fixed checkstyle issues * Updated code to reflect Abhiman's suggestions * Updated user guide to fit Export and Import Command * Updated code to reflect Joshua's comments * Fixed checkstyle issues * Fixed failing tests * Changed method name * Updated user guide to fit Export and Import Command * Updated ID regex and loading of entities * Updated ViewCommand and refactored listcommand * Fixed tests * Fixed checkstyle issues * Some changes on UI code * Changed IOException message * Add AlfredParserUtil Tests. * Remove project type field. * Updated ImportCommand to create an output csv file with errors if an exception is thrown while importing data * Deprecated ProjectType * Updated ImportCommand to create errorFile only if file path is specified * Add tests for AlfredParser. * Updated tests for ImportCommand and ImportCommandParser * Fix checkstyle errors. * Fixed checkstyle issues * save work. * Add more test cases for AlfredParser. * Fix disabled tests to work. * Add code for edit command. * Fixed PR issue * Add edit command parsers. * Fix checkstyle errors. * Corrected tests * Merged feat/deprecate-projecttype * Removed csv file * Deleted placeholders for assign commands * Fixed issues with deletion * Fixed tests * Fixed checkstyle issues * Created tests for DeleteMentorCommand * Removed @disabled for one test * Fixed travis issues * fixed checkstyle * Updated to enable jar files * Added ImportCommand details in DG * Updated EditCommand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Made changes to AboutUs.adoc and ContactUs.adoc
Checks
Changelog
Comments for Reviewer (if any)