Add Alfred Parsers #98
Conversation
Could you give more details on how to reproduce that second error (what you keyed on etc)? 1st one is expected behaviour for now because the ID checks are in yet. It seems like a storage/Fx bug for now. |
There was a problem hiding this comment.
Alright in general, but two things to note before merging apart from fixing the build.
- generate ID should now be called as a static method
- Standardization of command words. add Participant is
addParticipantbut in other places it does not seem to be the of the same format
As for the bug with team, I think it is good to merge cos Participant is working, we'll fix it later
Also help me review #86 thanks. If it's okay just help me approve and merge thanks i dont have wifi
For point 2, all other commands except addParticipant actually use the entity ID straight away since once it's created we can just identify the participant with the ID unlike when we are still creating it. But you are right, there should be maximum standardisation. If you have any suggestion on how to change it I am completely open. I could change everything to the format "commandEntity" (like viewParticipant) but what I thought was that it just requires extra cases in the AlfredParser. If you think that doesn't matter tho, I can change it to such. |
Just a normal addTeam command "add team n/Team 01 s/Social pn/Emotion Train pt/Public Welfare l/22". The message displayed says "This team already exists in this Hackathon". I am still looking into it to see where the problem is coming from. But any help would be appreciated |
| @@ -27,7 +27,7 @@ | |||
| + CliSyntax.PREFIX_NAME + "John Doe " | |||
| + CliSyntax.PREFIX_PHONE + "98765432 " | |||
| + CliSyntax.PREFIX_EMAIL + "johnd@example.com " | |||
| + CliSyntax.PREFIX_ORGANISATION + "Fill it up for me idk what this is..."; | |||
| + CliSyntax.PREFIX_ORGANISATION + "Google"; | |||
There was a problem hiding this comment.
I added the Message Usage for the commands 😃
| @@ -15,8 +15,8 @@ | |||
| */ | |||
| public class DeleteMentorCommand extends DeleteCommand { | |||
|
|
|||
| public static final String COMMAND_WORD = "delete"; | |||
| public static final String MESSAGE_INVALID_MENTOR_DISPLAYED_INDEX = "The mentor ID provided is invalid"; | |||
| public static final String MESSAGE_INVALID_MENTOR_DISPLAYED_INDEX = "The mentor ID provided is " | |||
There was a problem hiding this comment.
Oh so is it changed to just delete(the parser will automatically parse out the Entity type)? Do correct me if I am wrong hahaha 😄
There was a problem hiding this comment.
yup, the command_word is just delete. So when you do delete P-1, it automatically knows that P is associated with participant so it deletes Participant with ID P-1
| @@ -13,5 +13,6 @@ | |||
| public static final String MESSAGE_PERSONS_LISTED_OVERVIEW = "%1$d persons listed!"; | |||
| // to set restrictions as some operations can only be applied to some entity | |||
| public static final String MESSAGE_INVALID_TYPE = "The type of entity is invalid"; | |||
| public static final String MESSAGE_INVALID_INDEX = "Index is not a non-zero unsigned integer."; | |||
There was a problem hiding this comment.
The double negative seems a little confusing, how about MESSAGE_INVALID_INDEX = "Invalid index! Index should be a non-zero unsigned integer." haha just throwing out ideas :)
Description
Implements all the parsers required by Alfred.
Checks
Changelog
Comments for Reviewer (if any)
@hcwong The ID-ing of each entity still doesn't work properly. Could you just check and see whether I did something wrong when generating the ID (maybe I am not using the latest way of generating the ID in case you changed it)
@brianyenna and @hcwong I can't create a team at all. It instantly says that the team already exists but nothing is written to Storage.