S update testing #99
Merged
S update testing #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoyu-nus
reviewed
Oct 24, 2019
| @@ -56,13 +57,16 @@ private Quantity(int quantity) throws ParseException { | |||
| } | |||
|
|
|||
| public static boolean isValidQuantity(String test) { | |||
| return StringUtil.isNonNegativeInteger(test); | |||
| return StringUtil.isNonNegativeInteger(test) && Integer.parseInt(test) <= MAX_VALUE; | |||
There was a problem hiding this comment.
I actually added an isExceedingLimit method to the StringUtil class so you can use that
This was referenced Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #65 and #86
Add maximum limit for quantity
Fix bug for parsing in delete command
Update DG for Replenish List
https://objective-bartik-a0ad8e.netlify.com/developerguide#proposed-replenish-list