Info command #125
Merged
Info command #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cronyxx
reviewed
Oct 15, 2019
| @@ -5,18 +5,25 @@ | |||
| */ | |||
| public class Messages { | |||
There was a problem hiding this comment.
Do we want to consider splitting the messages into different classes? For example, BookMessages, CommandMessages, etc.
There was a problem hiding this comment.
We can look into it! If i'm not wrong the other PRs have new Messages as well so we can split it once we merge everyone's PR
| @@ -48,7 +50,7 @@ public void parse_missingParts_failure() { | |||
| assertParseFailure(parser, VALID_TITLE_BOOK_1, MESSAGE_INVALID_FORMAT); | |||
|
|
|||
| // no field specified | |||
| assertParseFailure(parser, "1", EditCommand.MESSAGE_NOT_EDITED); | |||
| assertParseFailure(parser, VALID_INDEX_ONE, EditCommand.MESSAGE_NOT_EDITED); | |||
There was a problem hiding this comment.
Good job replacing magic numbers with a symbolic constant!
| @@ -11,11 +11,14 @@ | |||
|
|
|||
| public class FindCommandParserTest { | |||
|
|
|||
| private static final String EMPTY_STRING = " "; | |||
There was a problem hiding this comment.
I think you can consider renaming this constant to SPACES instead of EMPTY_STRING as an empty string would tend to refer to "" in my opinion.
|
|
||
| private static final String VALID_INDEX_ONE = "1"; | ||
| private static final String VALID_INDEX_TWO = "2"; | ||
| private static final String EMPTY_STRING = " "; |
shiyao821
reviewed
Oct 16, 2019
Comment on lines
+49
to
+55
| private String getSerialNumberAsString(Book target) { | ||
| return target.getSerialNumber().toString(); | ||
| } | ||
|
|
||
| private String getTitleFromBook(Book target) { | ||
| return target.getTitle().toString(); | ||
| } |
There was a problem hiding this comment.
Good job using the toString() method instead of the exact value!
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.