Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Immutable loaning and returning #152

Merged
merged 4 commits into from Oct 22, 2019
Merged

Immutable loaning and returning #152

merged 4 commits into from Oct 22, 2019

Conversation

seeziyang
Copy link

@seeziyang seeziyang commented Oct 21, 2019 •
edited

Fixes #145

@seeziyang seeziyang changed the title Immutable loan Immutable loaning and returning Oct 21, 2019
hoholyin
hoholyin reviewed Oct 22, 2019
View reviewed changes
Copy link

@hoholyin hoholyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall comprehensive changes to make the class immutable!

src/main/java/seedu/address/model/BorrowerRecords.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/BorrowerRecords.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/ModelManager.java Show resolved Hide resolved
src/test/java/seedu/address/model/loan/LoanListTest.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/model/loan/LoanListTest.java Outdated Show resolved Hide resolved
hoholyin
hoholyin approved these changes Oct 22, 2019
View reviewed changes
Copy link

@hoholyin hoholyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hoholyin hoholyin merged commit 0b38946 into AY1920S1-CS2103T-F13-1:master Oct 22, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 25, 2019
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linyutinglyt linyutinglyt linyutinglyt left review comments

@hoholyin hoholyin hoholyin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make loaning/returning immutable (Loan and Borrower)
3 participants
@seeziyang @hoholyin @linyutinglyt