Edit borrower parser and tests #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 24, 2019 20:43
hoholyin
reviewed
Oct 26, 2019
| @@ -18,7 +19,7 @@ public static void assertParseSuccess(Parser parser, String userInput, Command e | |||
| try { | |||
| Command command = parser.parse(userInput); | |||
| assertEquals(expectedCommand, command); | |||
| } catch (ParseException pe) { | |||
| } catch (ParseException | CommandException pe) { | |||
There was a problem hiding this comment.
Should we catch and deal with them separately?
There was a problem hiding this comment.
Yup ok! It was auto-added by the IDE. Will change
| @@ -31,7 +32,7 @@ public static void assertParseFailure(Parser parser, String userInput, String ex | |||
| try { | |||
| parser.parse(userInput); | |||
| throw new AssertionError("The expected ParseException was not thrown."); | |||
| } catch (ParseException pe) { | |||
| } catch (ParseException | CommandException pe) { | |||
Because we are not going to use Edit Command so I was thinking of safely deleting the whole thing later on in 1.4 or something when we fix bugs and stuff. Now I just comment out first so that it doesn't affect our current progress |
hoholyin
reviewed
Oct 26, 2019
| */ | ||
| public void removeBorrower(Borrower borrower) { | ||
| listOfBorrowers.remove(borrower); | ||
| borrowersMap.remove(borrower); |
There was a problem hiding this comment.
I think the argument to be passed into borrowersMap.remove is the BorrowerId since that is the key. So should it be borrowersMap.remove(borrower.getBorrowerId())
hoholyin
approved these changes
Oct 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #137