Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UserGuide.adoc - more commands + v2.0 markers #94

Merged
merged 3 commits into from Sep 30, 2019
Merged

fix: UserGuide.adoc - more commands + v2.0 markers #94

merged 3 commits into from Sep 30, 2019

Conversation

shiyao821
Copy link

closes #42

@shiyao821 shiyao821 added this to the v1.1 milestone Sep 30, 2019
hoholyin
hoholyin reviewed Sep 30, 2019
View reviewed changes
Copy link

@hoholyin hoholyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor description that is not changed, the rest looks good!

docs/UserGuide.adoc Outdated
Loans the book with serial number B0041
* `loan sn/B0201 sn/B2929 sn/B0203` +
* `loan sn/B00201 sn/B02929 sn/B00203` +
Loans the books with serial numbers B0201, B2929 and B0203
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this too

linyutinglyt
linyutinglyt reviewed Sep 30, 2019
View reviewed changes
docs/UserGuide.adoc
Registers a new borrower to the library records. A unique ID associated with the borrower will automatically be generated. +
Format: `register u/NAME p/PHONE_NUMBER a/ADDRESS`
Registers a new borrower to the library records. A unique ID associated with the borrower will automatically be generated and displayed. Borrowers are expected to know his ID in order for loans to be processed+
Format: `register u/NAME p/PHONE_NUMBER e/EMAIL`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

linyutinglyt
linyutinglyt reviewed Sep 30, 2019
View reviewed changes
Copy link

@linyutinglyt linyutinglyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@seeziyang
Copy link

This can be merged! 👍

@seeziyang seeziyang merged commit a7c63ad into AY1920S1-CS2103T-F13-1:master Sep 30, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 3, 2019
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoholyin hoholyin hoholyin left review comments

@linyutinglyt linyutinglyt linyutinglyt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

Update UG
4 participants
@shiyao821 @seeziyang @hoholyin @linyutinglyt