Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned UI #136

Merged
merged 5 commits into from Oct 30, 2019
Merged

Redesigned UI #136

merged 5 commits into from Oct 30, 2019

Conversation

jonathantjendana
Copy link

image
image

choongyx
choongyx approved these changes Oct 29, 2019
View reviewed changes
Copy link

@choongyx choongyx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍👍👍

Can try deleting some of the unused files e.g statsChart and graphChart fxml and java files to increase coverage.

minpyaemoe
minpyaemoe reviewed Oct 30, 2019
View reviewed changes
Copy link

@minpyaemoe minpyaemoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The black color extra pane under the items are intended, right?

@Nanosync
Copy link

Nanosync commented Oct 30, 2019 •
edited

This is a good step towards a final design! I like the separators, very creative. However, I hope that the balance bar can be changed later. The reminders also seem to take up a lot of space and can be tweaked.

I cloned the repository and found some bugs:

  • The background of the list panel is incorrect
    image

  • The graph/stats panel items keep shifting when you click another tab pane and hit any key or focus on another element.
    image
    image

@jonathantjendana
- Removed unused loggers
ff2bffa 
- Removed unused files
- Changed listview background colour
- Bugfix moving charts
@jonathantjendana
Removed unused imports
cab9661
@Nanosync Nanosync merged commit 0b6a91f into AY1920S1-CS2103T-F13-3:master Oct 30, 2019
@jonathantjendana jonathantjendana deleted the branch-ui branch October 30, 2019 12:36
@choongyx choongyx added this to the v1.3 milestone Oct 30, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 31, 2019
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minpyaemoe minpyaemoe minpyaemoe approved these changes

@Nanosync Nanosync Nanosync approved these changes

@choongyx choongyx choongyx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonathantjendana @Nanosync @minpyaemoe @choongyx