Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base for natural language processing #55

Merged
merged 1 commit into from Oct 10, 2019
Merged

Add base for natural language processing #55

merged 1 commit into from Oct 10, 2019

Conversation

Nanosync
Copy link

@Nanosync Nanosync commented Oct 9, 2019

#27

@Nanosync Nanosync added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 9, 2019
@Nanosync Nanosync changed the title Add natural language processing Add base for natural language processing Oct 10, 2019
@Nanosync Nanosync marked this pull request as ready for review October 10, 2019 16:00
@Nanosync Nanosync removed the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 10, 2019
@austinsantoso
Copy link

austinsantoso commented Oct 10, 2019 •
edited

Looks good to merge

jonathantjendana
jonathantjendana approved these changes Oct 10, 2019
View reviewed changes
Copy link

@jonathantjendana jonathantjendana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

austinsantoso
austinsantoso approved these changes Oct 10, 2019
View reviewed changes
Copy link

@austinsantoso austinsantoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Nanosync Nanosync merged commit c348a77 into AY1920S1-CS2103T-F13-3:master Oct 10, 2019
choongyx
choongyx reviewed Oct 10, 2019
View reviewed changes
src/test/java/seedu/address/commons/util/DateUtilTest.java
class DateUtilTest {

@Test
public void parseDate_validDate() throws ParseException {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention for test names is methodName_testScenario_expectedResult. expectedResult seems to be missing.

@nus-se-bot nus-se-bot mentioned this pull request Oct 10, 2019
Open
21 tasks
@choongyx choongyx added this to the v1.2 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choongyx choongyx choongyx left review comments

@jonathantjendana jonathantjendana jonathantjendana approved these changes

@austinsantoso austinsantoso austinsantoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Nanosync @austinsantoso @jonathantjendana @choongyx