add Budget class, budget and showbudget command #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choongyx
reviewed
Oct 17, 2019
| private Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs()); | ||
|
|
||
| @Test | ||
| void execute_setNewBudget_success() { |
There was a problem hiding this comment.
public void --> to remain consistent with other tests and for code quality check
| private Model model = new ModelManager(getTypicalAddressBook(), new UserPrefs()); | ||
|
|
||
| @Test | ||
| void execute_displayBudget_success() { |
There was a problem hiding this comment.
public void --> to remain consistent with other tests and for code quality check
| */ | ||
| public class Budget { | ||
|
|
||
| public static final String MESSAGE_CONSTRAINTS = "Budget values should be positive number"; |
There was a problem hiding this comment.
Are we allowing 2dp for budget (like Cost) or budget can use Cost too?
add budget class, with save and load functionalities. added budget and show budget commands budget code quality
austinsantoso
force-pushed
the
branch-addingbudgetcommand
branch
from
5862b67
to
5a84051
Compare
Nanosync
reviewed
Oct 17, 2019
| import seedu.address.model.Model; | ||
|
|
||
| /** | ||
| * Displays the current SPending |
|
|
||
| @Test | ||
| public void parse_invalidArgs_throwsParseException() { | ||
| assertParseFailure(parser, "", String.format(MESSAGE_INVALID_COMMAND_FORMAT, |
There was a problem hiding this comment.
add a negative value argument for test case
add test cases for budget
austinsantoso
force-pushed
the
branch-addingbudgetcommand
branch
from
e5efd3b
to
1d83565
Compare
choongyx
approved these changes
Oct 17, 2019
Nanosync
approved these changes
Oct 17, 2019
26 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add budget class, with save and load functionalities. added budget and showbudget commands