Add find and sort to DG and fix UG bugs #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minpyaemoe
reviewed
Oct 23, 2019
| 'Since the beta syntax does not support placing the condition outside the | ||
| 'diamond we place it as the true branch instead. | ||
|
|
||
| if () then ([valid fields present]) |
There was a problem hiding this comment.
i think there should be two type of errors, right? like missing fields and invalid fields?
There was a problem hiding this comment.
The sequence diagram treats all these cases as else.
There was a problem hiding this comment.
But have different error messages, right? no?
choongyx
approved these changes
Oct 23, 2019
Nanosync
changed the title
|
Coverage drop is unrelated |
…branch-update-docs # Conflicts: # docs/DeveloperGuide.adoc
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updatetoeditin UG#92