Update variable names #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-4/main * 'branch-v1.2' of https://github.com/AY1920S1-CS2103T-F13-4/main: Fix lexicographical order of imports again Fix lexicographical order of imports Added javadocs for come classes Removed trailling whitespaces Organise the structure of the model package Included UniqueShowList, DuplicateShowException and ShowNotFoundException Edited Show, Movie, TvShow, TvSeason and Episode classes Create structure for the classes
…-4/main * 'branch-v1.2' of https://github.com/AY1920S1-CS2103T-F13-4/main: no message Added tv show method things to take note, the show model might not need all the variables in the constructor at creation, maybe can replace it with the required information first, then another method to check if all the information can be taken from the api images are also anothher thing that might be quite difficult to handle. Should we retrieve images online and download into resources so that it will be cached? Added the Api into the application added a placeholder image field in the show model class Added one method in Api Main
…-4/main into branch-v1.2-search-command * 'branch-v1.2' of https://github.com/AY1920S1-CS2103T-F13-4/main: Error still exist can't seem to find the interface Added rudimentary spellcheck classes for Michelle to take a look Added one MovieCard that has the same format as PersonCard so that we can start working on the interface changes Tweaked some of the API methods Refactored the name of the package from adress to ezwatchlist Added a movieInfromation class in the api package but might be unnecesarry. Could perhaps change the in-house movie class to be similar to that Restore travis checks Test if travis chekcs have been reduced by removing lastline no message no message Reduce travis checks Added model classes for watchlist Changed one line of use cases
|
I think might need to resolve the merge conflicts before adding your edits, |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.