Edit task command #100
Merged
Edit task command #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation (Eg. 1030 - 1200).
…sk. Deleted Customer List and Driver List because using UniquePersonList<T> now.
tysg
requested changes
Oct 20, 2019
| String startTimeStr = durationArr[0]; | ||
| String endTimeStr = durationArr[2]; | ||
|
|
||
| return parse(startTimeStr, endTimeStr); |
There was a problem hiding this comment.
Since this is a public facing static method, you may want to apply the regex check to duration to ensure that the input is in the correct form? Otherwise, duration[i] may throw IndexOutOfBoundError.
There was a problem hiding this comment.
Okay noted, because usually we check if is valid then we parse, so i didn't include it.
But for safety, i will include isValidDuration under the parse and create a IncorrectFormat exception for it to throw
| * Example: 1200 - 1330. | ||
| */ | ||
| public static String getStringFromDuration(EventTime duration) { | ||
| DateTimeFormatter jsonFormatter = DateTimeFormatter.ofPattern("Hmm"); |
tysg
approved these changes
Oct 20, 2019
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Edit task command
-refer to commits for updates
*Storage for tasks not done
-will do by Sunday.