Added savepdf Command. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into savepdf # Conflicts: # src/main/java/seedu/address/logic/parser/AddressBookParser.java
tysg
reviewed
Nov 2, 2019
|
|
||
| private static final String FILE_PATH_FOR_PDF = "./data/" + FILE_NAME + " %1$s.pdf"; | ||
|
|
||
| private final Clock clock; |
| * | ||
| * @throws ParseException if date format is invalid. | ||
| */ | ||
| public static LocalDate parseAnyDate(String date) throws ParseException { |
There was a problem hiding this comment.
This should replace parseDate. Parser shouldn't be checking if the day is before today actually, it's a parser so any date that is valid should pass.
There was a problem hiding this comment.
okay, check today on wards at command side
| } | ||
|
|
||
| try { | ||
| Optional<LocalDate> date = Optional.of(ParserUtil.parseAnyDate(args)); |
There was a problem hiding this comment.
Any reason with using Optional? Date should always be non null.
There was a problem hiding this comment.
savepdf has optional date input, so if there's no date input, then ill throw in a optional.empty() as parameter of the constructor
| * @param date date of delivery. | ||
| * @return filtered task list that contains only tasks on a specific date and are ONGOING or COMPLETE. | ||
| */ | ||
| private List<Task> filterTasksBasedOnDate(List<Task> tasks, LocalDate date) { |
There was a problem hiding this comment.
This code seems very familiar. If it's anywhere else, consider reusing that code.
tysg
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123
Format:
-savepdf
-savepdf [DATE]
Saves drivers' tasks into pdf format.