Improve schedule presentation #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junnbang
approved these changes
Nov 9, 2019
Comment on lines
+128
to
+129
| EventTime early = e1.compareTo(e2) > 0 ? e2 : e1; | ||
| EventTime late = e1.compareTo(e2) > 0 ? e1 : e2; |
There was a problem hiding this comment.
instead of using the same condition to check twice, use the condition once, and assign both early and late in true and false because once u execute the condition once, you already know the result of early and late
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #129, though it doesn't directly address the problem.
This PR enhances the string representation of schedule so that two connecting time will now show as one time. For example,
1400 - 1500, 1500 - 1600, 1600 - 1700will just show as1400 - 1700,