Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for logic package #120

Merged

Conversation

t-cheepeng
Copy link

@t-cheepeng t-cheepeng commented Oct 26, 2019

  • Edited CommandResultTest
  • Schedule and Resolve commands tests added
  • Schedule and Resolve parser tests added

@t-cheepeng t-cheepeng added this to the v1.3 milestone Oct 26, 2019
@t-cheepeng t-cheepeng marked this pull request as ready for review October 26, 2019 16:03
Copy link

@weihaw08 weihaw08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

private static final IOException DUMMY_IO_EXCEPTION = new IOException("dummy exception");

@TempDir
public Path temporaryFolder;

private Model model = new ModelManager();
private Storage storage;
private Logic logic;

@BeforeEach

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

* Contains test data that is commonly used throughout the test suites
*/
public class CommonTestData {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying up!

@t-cheepeng t-cheepeng merged commit 6dc46b6 into AY1920S1-CS2103T-T09-2:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants