Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature undo schedule and resolve #186

Conversation

garylyp
Copy link

@garylyp garylyp commented Nov 2, 2019

Changes made in this PR.

  1. Implement undo-redo feature for ScheduleRegimeCommand, ScheduleCompleteCommand and ResolveCommand.
  2. Add tests for the Events created for the above Undoable commands.
  3. Observable lists are now sorted (except for the suggest list).
  • Exercise List is ordered from most recent to least recent date. (decreasing date)
  • Regime list is order by name lexicographically.
  • Schedule list is ordered by nearest date to the furthest date into the future (increasing date)
  • Can't think of a metric to sort suggest list yet so will leave it unsorted for now

@garylyp garylyp requested review from t-cheepeng, weihaw08, jietung and kwekke and removed request for t-cheepeng November 2, 2019 08:20
@garylyp garylyp added this to the v1.4 milestone Nov 2, 2019
@t-cheepeng
Copy link

In the future, if you wish to edit the PR description, just add a new comment so it is more visible. Thanks

@t-cheepeng
Copy link

Please resolve the merge conflict before it can be merged. thanks

@garylyp
Copy link
Author

garylyp commented Nov 2, 2019

Sure. I was thinking it might be more visible if it's the first thing at the top of the page but actually anything works

@garylyp garylyp closed this Nov 2, 2019
@garylyp garylyp reopened this Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants