-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crud regime #90
Crud regime #90
Conversation
… into crud-regime
src/main/java/seedu/exercise/model/regime/UniqueRegimeList.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some parts are violating DRY principles but we can refactor out when doing schedule also.
private final UserPrefs userPrefs; | ||
private final FilteredList<Exercise> filteredExercises; | ||
private final SortedList<Exercise> sortedExercises; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a clarification, is there a reason why sortedExercises list was selected over filteredExercises list to be replaced by the filteredRegimes list?
Was it because sortedExercises list was just meant to be a filler for the left panel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. SortedExercises was just filler for the left panel.
src/main/java/seedu/exercise/logic/parser/DeleteCommandParser.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/exercise/logic/parser/AddCommandParser.java
Outdated
Show resolved
Hide resolved
@@ -51,7 +51,7 @@ | |||
</StackPane> | |||
<BorderPane prefHeight="58.0" prefWidth="410.0" styleClass="pane-with-border" VBox.vgrow="ALWAYS"> | |||
<left> | |||
<StackPane fx:id="sortedListPanelPlaceholder" minHeight="150.0" minWidth="100.0" | |||
<StackPane fx:id="regimeListPanelPlaceholder" minHeight="150.0" minWidth="100.0" | |||
prefHeight="150.0" prefWidth="400.0" BorderPane.alignment="CENTER"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation is the regime list on Left panel and exercise list on Right panel. Nothing wrong with it for now, and it is very simple to switch sides from this fxml file. But if I remembered correctly, the original idea has exercise list on left and regime list on right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its regimes on the left and schedule on the right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mock up UI in user guide is regime list on the right, left is schedule list.
As for the middle, i think is result display?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will discuss the finalized UI design on our next meeting then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh okay I might have remembered wrongly then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was very efficient. Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok.
No description provided.