Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commands and parsers for Phone class and edit sampleDataUtil #102

Merged
merged 12 commits into from Oct 13, 2019

Conversation

zhixianggg
Copy link

@zhixianggg zhixianggg commented Oct 9, 2019

Add AddPhoneCommand, EditPhoneCommand and DeletePhoneCommand.
Also added the parsers along with it.
Edit SampleDataUtil to populate app with sample customer and phone data.

@zhixianggg zhixianggg added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 9, 2019
@zhixianggg zhixianggg self-assigned this Oct 9, 2019
@EugeneTeu EugeneTeu added priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new labels Oct 9, 2019
@EugeneTeu EugeneTeu added this to the v1.2 milestone Oct 9, 2019
@zhixianggg zhixianggg changed the title Add commands and parsers for Phone class. Add commands and parsers for Phone class and edit sampleDataUtil Oct 9, 2019
Copy link

@qiujiaaa qiujiaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!


import static java.util.Objects.requireNonNull;
import static seedu.address.logic.parser.CliSyntax.PREFIX_CONTACT;
import static seedu.address.logic.parser.CliSyntax.PREFIX_EMAIL;
import static seedu.address.logic.parser.CliSyntax.PREFIX_NAME;
import static seedu.address.logic.parser.CliSyntax.PREFIX_TAG;

import seedu.address.logic.commands.Command;
import seedu.address.logic.commands.CommandResult;
import seedu.address.logic.commands.PanelType;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be updated to UiChange?

src/main/java/seedu/address/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/phone/Capacity.java Outdated Show resolved Hide resolved
# Conflicts:
#	src/main/java/seedu/address/logic/parser/AddressBookParser.java
#	src/main/java/seedu/address/logic/parser/SellerManagerParser.java
Copy link

@yan-wl yan-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job!

Comment on lines 280 to 282



Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary new lines

src/main/java/seedu/address/logic/parser/ParserUtil.java Outdated Show resolved Hide resolved
src/main/java/seedu/address/model/phone/Capacity.java Outdated Show resolved Hide resolved
@yan-wl yan-wl merged commit c190b8b into AY1920S1-CS2103T-T09-4:master Oct 13, 2019
@EugeneTeu EugeneTeu removed the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic. e.g. Move testing code into a new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants