Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Model #137

Merged
merged 14 commits into from Oct 19, 2019
Merged

Refactor Model #137

merged 14 commits into from Oct 19, 2019

Conversation

yan-wl
Copy link

@yan-wl yan-wl commented Oct 17, 2019

No description provided.

@EugeneTeu EugeneTeu added this to the v1.3 milestone Oct 17, 2019
@EugeneTeu EugeneTeu added type.Bug A bug priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Oct 17, 2019
EugeneTeu
EugeneTeu approved these changes Oct 17, 2019
View reviewed changes
Copy link

@EugeneTeu EugeneTeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing wrong!

@yan-wl yan-wl changed the title Refactor UniqueList Refactor Model Oct 18, 2019
zhixianggg
zhixianggg requested changes Oct 19, 2019
View reviewed changes
Copy link

@zhixianggg zhixianggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to have a DataBookTest i think

@zhixianggg zhixianggg merged commit 55453ba into AY1920S1-CS2103T-T09-4:master Oct 19, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 23, 2019
Open
23 tasks
@nus-se-bot nus-se-bot mentioned this pull request Oct 30, 2019
Open
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhixianggg zhixianggg zhixianggg approved these changes

@EugeneTeu EugeneTeu EugeneTeu approved these changes

Assignees

@yan-wl yan-wl

Labels
priority.High Must do severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug A bug
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yan-wl @zhixianggg @EugeneTeu