create customer class #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-wl
reviewed
Sep 26, 2019
EugeneTeu
requested review from
yan-wl,
yeodonghan and
a team
and removed request for
a team
qiujiaaa
reviewed
Sep 27, 2019
|
|
||
|
|
||
| public static final String MESSAGE_CONSTRAINTS = | ||
| "ContactNumber numbers should only contain numbers, and it should be at least 3 digits long"; |
There was a problem hiding this comment.
contact number should be 8 numbers instead i think
qiujiaaa
reviewed
Sep 27, 2019
|
|
||
| /** | ||
| * Returns true if both customers have the same identity and data fields. | ||
| * This defines a stronger notion of equality between two persons. |
yan-wl
reviewed
Sep 27, 2019
|
|
||
| public static final String MESSAGE_CONSTRAINTS = | ||
| "ContactNumber numbers should only contain numbers, and it should be at least 8 digits long"; | ||
| public static final String VALIDATION_REGEX = "\\d{3,}"; |
| import seedu.address.commons.util.StringUtil; | ||
|
|
||
| /** | ||
| * Tests that a {@code Person}'s {@code Name} matches any of the keywords given. |
| } | ||
|
|
||
| /** | ||
| * Adds a person to the list. |
| */ | ||
| public class CustomerCard extends UiPart<Region> { | ||
|
|
||
| private static final String FXML = "PersonListCard.fxml"; |
There was a problem hiding this comment.
Perhaps leave a TODO to remind to change when the fxml is ready
| * Panel containing the list of persons. | ||
| */ | ||
| public class CustomerListPanel extends UiPart<Region> { | ||
| private static final String FXML = "PersonListPanel.fxml"; |
| } | ||
|
|
||
| /** | ||
| * Custom {@code ListCell} that displays the graphics of a {@code Person} using a {@code PersonCard}. |
qiujiaaa
reviewed
Sep 27, 2019
| /** | ||
| * Replaces the customer {@code target} in the list with {@code editedCustomer}. | ||
| * {@code target} must exist in the list. | ||
| * The person identity of {@code editedCustomer} must not be the same as another existing customer in the list. |
qiujiaaa
reviewed
Sep 27, 2019
|
|
||
| /** | ||
| * Removes the equivalent customer from the list. | ||
| * The person must exist in the list. |
qiujiaaa
reviewed
Sep 27, 2019
| import seedu.address.model.customer.exceptions.DuplicateCustomerException; | ||
|
|
||
| /** | ||
| * A list of persons that enforces uniqueness between its elements and does not allow nulls. |
There was a problem hiding this comment.
all the persons should be changed to customer i think
yan-wl
approved these changes
Sep 27, 2019
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.