Add list panels and first UI prototype #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneTeu
commented
Sep 28, 2019
| @@ -13,14 +13,14 @@ | |||
| SIZE_512GB("512GB"), | |||
| SIZE_1024GB("1024GB"); | |||
|
|
|||
| private final String label; | |||
| public final String value; | |||
There was a problem hiding this comment.
@uberSaiyan as discussed, switched this to value to keep with convention in PhoneCard
EugeneTeu
commented
Sep 28, 2019
| @@ -1,4 +1,4 @@ | |||
| package seedu.address.ui; | |||
| package seedu.address.ui.cards; | |||
EugeneTeu
commented
Sep 28, 2019
| @@ -0,0 +1,83 @@ | |||
| package seedu.address.ui.cards; | |||
EugeneTeu
commented
Sep 28, 2019
| @@ -0,0 +1,48 @@ | |||
| package seedu.address.ui.panels; | |||
EugeneTeu
requested review from
qiujiaaa,
yeodonghan,
zhixianggg and
yan-wl
zhixianggg
reviewed
Sep 28, 2019
EugeneTeu
commented
Sep 28, 2019
| @@ -32,7 +32,7 @@ | |||
| @FXML | |||
| private Label name; | |||
| @FXML | |||
| private Label id; | |||
| private Label index; | |||
yan-wl
reviewed
Sep 28, 2019
| * Panel containing the list of phones. | ||
| */ | ||
| public class PhoneListPanel extends UiPart<Region> { | ||
| private static final String FXML = "PersonListPanel.fxml"; |
|
|
||
| /** | ||
| * Panel containing the list of persons. | ||
| * Panel containing the list of customers. | ||
| */ | ||
| public class CustomerListPanel extends UiPart<Region> { | ||
| private static final String FXML = "PersonListPanel.fxml"; |
zhixianggg
approved these changes
Sep 28, 2019
| </HBox> | ||
| <FlowPane fx:id="tags" /> | ||
| <Label fx:id="contactNumber" styleClass="cell_small_label" text="\$contactNumber" /> | ||
| <Label fx:id="email" styleClass="cell_small_label" text="\$email" /> |
There was a problem hiding this comment.
I think need to update right? haha all the labels
34 tasks
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created PhoneListPanel and PhoneCard
Adjusted UI