Tabbed panels #72
Merged
Tabbed panels #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To ease the pain of you guys trying to read my code, Right now is some dummy fields that I put inside (4 identical Person panel) to test |
|
It looks okay, now have to figure out how to switch the tabs |
qiujiaaa
reviewed
Oct 2, 2019
34 tasks
|
Nicely done! |
yeodonghan
approved these changes
Oct 3, 2019
| @@ -160,9 +168,9 @@ private void handleExit() { | |||
| primaryStage.hide(); | |||
| } | |||
|
|
|||
| public PersonListPanel getPersonListPanel() { | |||
| /*public PersonListPanel getPersonListPanel() { | |||
There was a problem hiding this comment.
You might want to clean up commented-out lines later on.
qiujiaaa
approved these changes
Oct 3, 2019
yan-wl
approved these changes
Oct 4, 2019
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GET DIS UI TO WERK