OrderList and ScheduleList fxml #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into tutorial-adding-command
yeodonghan
changed the title
EugeneTeu
reviewed
Oct 1, 2019
| <Label fx:id="orderId" styleClass="cell_small_label" text="\$orderId" /> | ||
| <Label fx:id="customerName" styleClass="cell_small_label" text="\$customerName" /> | ||
| <Label fx:id="phoneName" styleClass="cell_small_label" text="\$phoneName" /> | ||
| <Label fx:id="phoneColour" styleClass="cell_small_label" text="\$phoneColour" /> |
There was a problem hiding this comment.
@uberSaiyan @qiujiaaa @zhixianggg Order for Model does not have Colour and Capacity but should we add it in? or we just use the phone in that order to access instead ?
I think we should stick with the latter as no phone means no order
There was a problem hiding this comment.
can just use the phone to access i think!
There was a problem hiding this comment.
I think accessing through phone is fine
qiujiaaa
reviewed
Oct 2, 2019
| <Label fx:id="orderId" styleClass="cell_small_label" text="\$orderId" /> | ||
| <Label fx:id="customerName" styleClass="cell_small_label" text="\$customerName" /> | ||
| <Label fx:id="phoneName" styleClass="cell_small_label" text="\$phoneName" /> | ||
| <Label fx:id="phoneColour" styleClass="cell_small_label" text="\$phoneColour" /> |
There was a problem hiding this comment.
I think accessing through phone is fine
34 tasks
EugeneTeu
approved these changes
Oct 3, 2019
qiujiaaa
approved these changes
Oct 3, 2019
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fxml for OrderListCard, OrderListPanel, ScheduleListCard and ScheduleListPanel.