Add customer order schedule tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiujiaaa
commented
Oct 7, 2019
| @@ -23,11 +22,7 @@ void isSamePhone() { | |||
| assertTrue(IPHONEONE.isSamePhone(IPHONEONE)); | |||
|
|
|||
| // clone -> returns true | |||
| try { | |||
| assertTrue(IPHONEONE.isSamePhone((Phone) IPHONEONE.clone())); | |||
There was a problem hiding this comment.
edited method signature for clone() so there is no need to catch exception anymore, changed it cuz the exception causes further implications in other classes
| && otherOrder.getPhone().equals(getPhone()) | ||
| && otherOrder.getPrice().equals(getPrice()) | ||
| && otherOrder.getStatus().equals(getStatus()) | ||
| && otherOrder.getSchedule().equals(getSchedule()) |
There was a problem hiding this comment.
removed schedule cuz it might still be null
There was a problem hiding this comment.
I think can still include schedule. We can use this equals more universally.
qiujiaaa
added
the
status.Ongoing
yeodonghan
approved these changes
Oct 8, 2019
| && otherOrder.getPhone().equals(getPhone()) | ||
| && otherOrder.getPrice().equals(getPrice()) | ||
| && otherOrder.getStatus().equals(getStatus()) | ||
| && otherOrder.getSchedule().equals(getSchedule()) |
There was a problem hiding this comment.
I think can still include schedule. We can use this equals more universally.
zhixianggg
reviewed
Oct 8, 2019
| public class OrderTest { | ||
|
|
||
| private static final String VALID_PRICE = "$1021"; | ||
| private static final Status VALID_STATUS = Status.CANCELLED; |
zhixianggg
approved these changes
Oct 8, 2019
yan-wl
approved these changes
Oct 8, 2019
| // invalid contact numbers | ||
| assertFalse(ContactNumber.isValidContactNumber("")); // empty string | ||
| assertFalse(ContactNumber.isValidContactNumber(" ")); // spaces only | ||
| assertFalse(ContactNumber.isValidContactNumber("91")); // less than 3 numbers |
This was referenced Oct 9, 2019
EugeneTeu
removed
the
status.Ongoing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.