Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Undo Functionality to Application #19

Merged
merged 6 commits into from Sep 28, 2019
Merged

Integrate Undo Functionality to Application #19

merged 6 commits into from Sep 28, 2019

Conversation

marcfyk
Copy link

@marcfyk marcfyk commented Sep 28, 2019

Add Undo capability to application.

Storage and redo has not been integrated yet.

marcfyk added 6 commits September 29, 2019 00:03
Move all address commands' parser tests classes to address sub-package
bc45922
Add method to VersionControl
19c2a57 
Add method in VersionControl to get the total number of available commands that can be undone.
Change UndoCommand
597c69d 
Override equals method to allow for comparisons.

Update MESSAGE_USAGE.
Modify syncVersionControl
95cd5d5
Add UndoCommandParser
3ee2c5e 
Add prefix for undo commands.

Add UndoCommandParser to parse undo commands.

Add tests to check behaviour for UndoCommandParser.
Integrate Undo Command into JarvisParser
77eb5e9 
Included undo commands into JarvisParser.

Add tests to ensure JarvisParser parses undo commands correctly.
@marcfyk marcfyk merged commit 3a93ec6 into AY1920S1-CS2103T-T10-1:master Sep 28, 2019
@marcfyk
Copy link
Author

marcfyk commented Sep 28, 2019 •
edited

Updates

  • Undo commands has been integrated to the application
  • Command format: undo [r/UNDO]
  • Optional Arguments: [r/UNDO] can be either a positive integer number or "all" (case insensitive), if a float is given there will be an error, if 0 or a negative number is given, it will be set to default value of 1.

Pending

  • Redo commands
  • Storage implementation

@marcfyk marcfyk added this to the Integrate Undo / Redo Feature milestone Oct 1, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 2, 2019
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marcfyk