Add planner UI #196

nishcafe · 2019-10-30T09:09:43Z

No description provided.

Update repo

Update branch

ryanYtan · 2019-10-30T09:20:37Z

src/main/resources/view/TaskListCard.fxml

+                <Label fx:id="taskDes" text="\$first" styleClass="cell_big_label" />
+            </HBox>
+            <FlowPane fx:id="tags" />
+            <Label fx:id="priority" styleClass="cell_small_label" text="\priority" />


Remove \ from here and from the other Labels, Java is interpreting this as escaping a character. PersonListCard uses a $ inside theirs which they need to escape.

Update repo

ryanYtan · 2019-10-30T14:53:12Z

src/main/java/seedu/jarvis/logic/commands/planner/AddTaskCommand.java

@@ -47,7 +49,7 @@
    public static final String MESSAGE_INVERSE_SUCCESS_DELETE = "Deleted task: %1$s";
    public static final String MESSAGE_INVERSE_TASK_NOT_FOUND = "Task already deleted: %1$s";

-    public static final boolean HAS_INVERSE = true;
+    public static final boolean HAS_INVERSE = false;


Is this supposed to be false?

ryanYtan · 2019-10-30T14:53:48Z

src/main/java/seedu/jarvis/logic/commands/planner/DeleteTaskCommand.java

@@ -32,7 +34,7 @@
    public static final String MESSAGE_INVERSE_SUCCESS_ADD = "New task added task: %1$s";
    public static final String MESSAGE_INVERSE_TASK_TO_ADD_ALREADY_EXIST = "Task already added: %1$s";

-    public static final boolean HAS_INVERSE = true;
+    public static final boolean HAS_INVERSE = false;


Same as above - I think it's not supposed to be false.

ryanYtan · 2019-10-30T14:54:13Z

src/main/java/seedu/jarvis/logic/commands/planner/DoneTaskCommand.java

@@ -35,7 +37,7 @@
    public static final String MESSAGE_INVERSE_SUCCESS_UNDONE = "%1$s marked as undone.";
    public static final String MESSAGE_INVERSE_TASK_ALREADY_UNDONE = "Task has already been marked as undone";

-    public static final boolean HAS_INVERSE = true;
+    public static final boolean HAS_INVERSE = false;


Same as above.

ryanYtan · 2019-10-30T14:56:08Z

src/main/java/seedu/jarvis/model/planner/enums/TaskType.java

+     */
+    Todo,
+    Event,
+    Deadline


Pretty sure enum values should be in upper-case.

ryanYtan · 2019-10-30T15:00:52Z

src/test/java/seedu/jarvis/logic/commands/planner/AddTaskCommandTest.java

@@ -22,7 +22,7 @@
    void hasInverseExecution_success() {
        Task t = new Todo("borrow book");
        AddTaskCommand command = new AddTaskCommand(t);
-        assertTrue(command.hasInverseExecution());
+        assertFalse(command.hasInverseExecution());


Change test for this to reflect if you changed HAS_INVERSE.

ryanYtan · 2019-10-30T15:01:02Z

src/test/java/seedu/jarvis/logic/commands/planner/DeleteTaskCommandTest.java

@@ -36,7 +36,7 @@ void getTargetIndex() throws ParseException {
    @Test
    void hasInverseExecution() throws ParseException {
        DeleteTaskCommand command = new DeleteTaskCommand(parseIndex("2"));
-        assertTrue(command.hasInverseExecution());
+        assertFalse(command.hasInverseExecution());


Save as above.

ryanYtan · 2019-10-30T15:01:09Z

src/test/java/seedu/jarvis/logic/commands/planner/DoneTaskCommandTest.java

@@ -32,7 +32,7 @@ void getCommandWord() {
    @Test
    void hasInverseExecution() {
        DoneTaskCommand command = new DoneTaskCommand(parseIndex("2"));
-        assertTrue(command.hasInverseExecution());
+        assertFalse(command.hasInverseExecution());


Same as above.

ryanYtan

Mostly just changes from testing, and a bit of style.

nishcafe added 11 commits October 27, 2019 12:21

Merge pull request #42 from AY1920S1-CS2103T-T10-1/master

65954be

Update repo

Change all HAS_INVERSE to false

63b7c64

Add TaskCard

b9d8ad9

Add TaskListPanel

ad98d28

Add fxml file for TaskListCard

5f3eb84

Add fxml file for TaskListPanel

8bae293

Merge pull request #43 from AY1920S1-CS2103T-T10-1/master

63c01fc

Update repo

Merge pull request #44 from nishcafe/master

5706c01

Update branch

Add TaskListView class

7df206a

Update UI for Planner

3b7a744

Update ui

c0091b8

nishcafe self-assigned this Oct 30, 2019

nishcafe added feature.Planner priority.High Must do type.Task Something that needs to be done, but not a story, bug, or an epic labels Oct 30, 2019

ryanYtan reviewed Oct 30, 2019

View reviewed changes

nishcafe added 10 commits October 30, 2019 17:28

Fix fxml file

c5d26db

Fix null pointer exception

41636e8

Update UI

c737856

Fix tests

01f3090

Fix checkstyle errors

f61dbd7

Merge pull request #45 from AY1920S1-CS2103T-T10-1/master

b84b8be

Update repo

Merge branch 'master' into task-card

98ad136

Fix checkstyle errors

85d11f1

Add EOF

5c56ec7

Update tests & javadocs

60fea5f

ryanYtan reviewed Oct 30, 2019

View reviewed changes

nishcafe added 2 commits October 30, 2019 23:09

Fix inverse commands

f1add59

Update inverse for DoneTask

a683147

marcfyk merged commit 2621b0b into AY1920S1-CS2103T-T10-1:master Oct 30, 2019

nus-se-bot mentioned this pull request Oct 30, 2019

Feedback on week 11 project progress for CS2103T-T10-1 #204

Closed

27 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add planner UI #196

Add planner UI #196

nishcafe commented Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan Oct 30, 2019

ryanYtan left a comment

Add planner UI #196

Add planner UI #196

Conversation

nishcafe commented Oct 30, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ryanYtan left a comment

Choose a reason for hiding this comment