Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DG, remove "Address" from code #365

Merged
merged 5 commits into from Nov 8, 2019
Merged

Update DG, remove "Address" from code #365

merged 5 commits into from Nov 8, 2019

Conversation

ryanYtan
Copy link

@ryanYtan ryanYtan commented Nov 7, 2019

No description provided.

@ryanYtan ryanYtan added the priority.High Must do label Nov 7, 2019
@ryanYtan ryanYtan added this to the v1.4 milestone Nov 7, 2019
marcfyk
marcfyk reviewed Nov 7, 2019
View reviewed changes
Copy link

@marcfyk marcfyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have to run through the uml diagrams again probably over the weekend as the styling not standardized yet, as well as some outdated AB3 diagrams.

@mrnewguy mrnewguy merged commit 823c8e3 into AY1920S1-CS2103T-T10-1:master Nov 8, 2019
@ryanYtan ryanYtan mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcfyk marcfyk marcfyk left review comments

@mrnewguy mrnewguy Awaiting requested review from mrnewguy

@gohsnn gohsnn Awaiting requested review from gohsnn

@nishcafe nishcafe Awaiting requested review from nishcafe

Assignees
No one assigned
Labels
priority.High Must do
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanYtan @marcfyk @mrnewguy