Create reminder #119
Merged
Create reminder #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannggoo
approved these changes
Oct 16, 2019
| //TODO: Check if Optional is present before .get() | ||
| reminder = reminders.get(0).getReminder().get(); | ||
| synchronized (reminders) { | ||
| while (reminder != null && reminder.getDateTime().isBefore(LocalDateTime.now())) { |
There was a problem hiding this comment.
Great work! Just wondering, how do you handle the case where the reminder is before the LocalDateTime? Does it inform the user?
There was a problem hiding this comment.
Sorry, could you clarify what you mean? The code above handles the case where the reminder is before the LocalDateTime.now(). On the off-chance you meant to ask if the reminder is after LocalDateTime.now() then it should remain in reminders list as the loop continues to check for reminders that are due to show.
26 tasks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.