Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Show Command to switch tabs. #72

Merged
merged 14 commits into from Oct 9, 2019

Conversation

Icesiolz
Copy link
Collaborator

@Icesiolz Icesiolz commented Oct 9, 2019

No description provided.

sianghwee
sianghwee previously approved these changes Oct 9, 2019
Copy link

@sianghwee sianghwee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge!

Copy link

@blimyj blimyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to change the switching of the model view to rely on the model instead? Not sure if this will come back to bite us but it seems like you did the switching of the model view at the UI level instead of the model level contrary to what AB3 did.

blimyj
blimyj previously approved these changes Oct 9, 2019
Copy link

@blimyj blimyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

mannggoo
mannggoo previously approved these changes Oct 9, 2019
Comment on lines +28 to +38
case "T":
this.targetList = "task";
break;
case "E":
this.targetList = "event";
break;
case "R":
this.targetList = "reminder";
break;
case "C":
this.targetList = "event";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these cases, maybe you can consider storing the strings T E R C in a final variable?

@Icesiolz Icesiolz dismissed stale reviews from mannggoo and blimyj via ef77ae8 October 9, 2019 14:39
Copy link

@mannggoo mannggoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

Copy link

@blimyj blimyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blimyj blimyj merged commit 8c0f21e into AY1920S1-CS2103T-T10-3:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants