Add UniqueIdentifier field to Expense for Equality checking between Expenses. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename Name class to Description class Rename 'name' in fields and methods containing the word with 'description'
Note: caused regression in reading json files
Note: Need to fix test cases
Change GUI to show price more clearly
Expenses now determine equality using a randomly generated unique id, but no response from teachers
add class UniqueIdentifier so that isSameExpense functionality does not change.
Resolve merge conflicts after merge
Add randomly generated UniqueIdentifier to allow checking of equality between Expenses as Expense does not have Identiy fields like Person
Unit tests which check that success of add command cannot be checked by comparing with another addcommand instance with the same arguments as equality of Expense is determined by a unique identifier randomly assigned. Unit tests which used to check for failiure when editing an expense to have the same fields as another should no longer fail as the identity of an Expense is determined by its unique identifier which cannot be edited.
briyanii
changed the title
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2 #3 #4 #10 #18
Add UniqueIdentifier field to Expense to allow checking of equality between Expenses, replacing Identity fields in the original Person class.