Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats Branch #234

Merged
merged 4 commits into from Nov 4, 2019
Merged

Stats Branch #234

merged 4 commits into from Nov 4, 2019

Conversation

eshwarkp
Copy link

@eshwarkp eshwarkp commented Nov 4, 2019

Updated AddressBookParser
Updated StatisticsCommand and modified to GenerateStatisticsCommand.

@eshwarkp eshwarkp added this to the v1.4 milestone Nov 4, 2019
@eshwarkp eshwarkp self-assigned this Nov 4, 2019
Copy link

@calvincxz calvincxz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@@ -278,6 +296,14 @@ public CommandResult executeCommand(String commandText) throws CommandException,
generateDate();
}

if (commandResult.getType().equals("Summary")) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this used?

* Opens the date window or focuses on it if it's already opened.
*/
@FXML
public void generateSummary() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so ur stats also have popup? shouldnt it be all in the stats window?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants