New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bugs #273
fix bugs #273
Conversation
…11-3/main into calvin_branch
…11-3/main into calvin_branch
|
||
public DeallocateCommand(Index eventIndex) { | ||
this.eventIndex = eventIndex; | ||
this.employeeId = null; | ||
} | ||
|
||
public DeallocateCommand(Index eventIndex, String employeeId) { | ||
public DeallocateCommand(Index eventIndex, EmployeeId employeeId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good fix
return eventIndex.equals(e.eventIndex) | ||
&& employeeId.equals(e.employeeId); | ||
&& (employeeId == e.employeeId || employeeId.equals(e.employeeId)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not just employeeId.equals(e.employeeId)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cos have null~~
@@ -98,10 +98,10 @@ public EventDateTimeMap getEventDateTimeMap() { | |||
* Checks if an employee is available for this event. | |||
* | |||
* @param employee to check | |||
* @param filteredEventList a complete event list. | |||
* @param fullEventList a complete event list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think its missing a @return
} else { | ||
return false; | ||
} | ||
return MainWindow.getCurrentTabIndex() == 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opps thanks for the catch LOL
No description provided.