Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fetch command (no manpower list display) and some test #83

Merged
merged 3 commits into from Oct 16, 2019
Merged

added fetch command (no manpower list display) and some test #83

merged 3 commits into from Oct 16, 2019

Conversation

calvincxz
Copy link

basic skeleton for fetch command, without showing manpower list associated with event

shihaoyap
shihaoyap reviewed Oct 16, 2019
View reviewed changes
Copy link

@shihaoyap shihaoyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks to be in order. Thanks for the work

shihaoyap
shihaoyap approved these changes Oct 16, 2019
View reviewed changes
Copy link

@shihaoyap shihaoyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Proper coding practices followed. Thanks

@shihaoyap shihaoyap merged commit 11b8694 into master Oct 16, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 16, 2019
Closed
25 tasks
@DivineDX DivineDX deleted the fetch_command branch October 17, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihaoyap shihaoyap shihaoyap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calvincxz @shihaoyap