Merge pull request #195 from jeunhoe/edit-person-command

Fix EditCommand to change person details in training records

src/main/java/seedu/address/logic/commands/EditCommand.java

@@ -88,6 +88,7 @@ public CommandResult execute(Model model) throws CommandException {
         }
 
         model.setPerson(personToEdit, editedPerson);
+        model.editPersonTrainingRecords(personToEdit, editedPerson);
         model.updateFilteredPersonList(PREDICATE_SHOW_ALL_PERSONS);
         return new CommandResult(String.format(MESSAGE_EDIT_PERSON_SUCCESS, editedPerson));
     }

src/main/java/seedu/address/model/Attendance.java

@@ -58,6 +58,17 @@ public int compare(Training first, Training second) {
         });
     }
 
+    /**
+     * Replaces all occurences of person at {@code target} with {@code editedPerson} in training records.
+     */
+    void editPersonTrainingRecords(Person target, Person editedPerson) {
+        for (Training training: trainings) {
+            if (training.hasPerson(target)) {
+                training.editPersonDetails(target, editedPerson);
+            }
+        }
+    }
+
     /**
      * Checks if there has been a Training at input date.
      *

src/main/java/seedu/address/model/Model.java

@@ -110,6 +110,11 @@ public interface Model {
      */
     void addTraining(Training training);
 
+    /**
+     * Replaces all occurences of person at {@code target} with {@code editedPerson} in training records.
+     */
+    void editPersonTrainingRecords(Person target, Person editedPerson);
+
     /**
      * Removes training on {@code date}
      */

src/main/java/seedu/address/model/ModelManager.java

@@ -229,6 +229,11 @@ public void addTraining(Training training) {
         this.attendance.addTraining(training);
     }
 
+    @Override
+    public void editPersonTrainingRecords(Person target, Person editedPerson) {
+        this.attendance.editPersonTrainingRecords(target, editedPerson);
+    }
+
     @Override
     public boolean hasTrainingOnDate(AthletickDate date) {
         return this.attendance.hasTrainingOnDate(date);

src/main/java/seedu/address/model/training/Training.java

@@ -77,4 +77,15 @@ public List<Person> getAbsentees() {
         }
         return listOfAbsentees;
     }
+
+    /**
+     * Replaces person data in the training record. Called when a person is edited.
+     */
+    public void editPersonDetails(Person target, Person editedPerson) {
+        assert(this.hasPerson(target)); // done in other calls
+
+        boolean hasAttended = this.hasPersonAttended(target);
+        this.trainingAttendance.remove(target);
+        this.trainingAttendance.put(editedPerson, hasAttended);
+    }
 }

src/test/java/seedu/address/logic/commands/AddCommandTest.java

@@ -179,6 +179,11 @@ public void addTraining(Training training) {
             throw new AssertionError("This method should not be called.");
         }
 
+        @Override
+        public void editPersonTrainingRecords(Person target, Person editedPerson) {
+            throw new AssertionError("This method should not be called.");
+        }
+
         @Override
         public void deleteTrainingOnDate(AthletickDate date) {
             throw new AssertionError("This method should not be called.");

src/test/java/seedu/address/logic/commands/EventCommandTest.java

@@ -222,6 +222,11 @@ public void addTraining(Training training) {
             throw new AssertionError("This method should not be called.");
         }
 
+        @Override
+        public void editPersonTrainingRecords(Person target, Person editedPerson) {
+            throw new AssertionError("This method should not be called.");
+        }
+
         @Override
         public void deleteTrainingOnDate(AthletickDate date) {
             throw new AssertionError("This method should not be called.");