Person -p flag for deleting #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 240
💛 - Coveralls |
jeunhoe
reviewed
Nov 4, 2019
| */ | ||
| public class DeleteCommand extends Command { | ||
| public abstract class DeleteCommand extends Command { |
There was a problem hiding this comment.
Wow! 😯Great idea 💡making this an abstract class! I 🙋♂️ personally wouldn't have thought 💭 of it myself! This will make implementing the delete training command a lot easier!
| * A flag that marks the beginning of a type that the command is applied to. | ||
| * E.g. '-p' in 'delete -p 1'. | ||
| */ | ||
| public class Flag { |
There was a problem hiding this comment.
Great abstraction of the flag class. Will be useful for my training command as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable @jeunhoe and I to use
delete -tanddelete -eflags to deleteTrainingandEventrespectively, as thedeletecommand will no longer be reserved for deleting a person.