Bad FlashCards/ Deadline - v1.3 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShuTingY
reviewed
Oct 30, 2019
| @@ -30,6 +30,9 @@ public DeadlinePanel(Deadline deadline, int displayedIndex) { | |||
| this.deadline = deadline; | |||
| id.setText(displayedIndex + ". "); | |||
| task.setText(deadline.getTask().toString()); | |||
There was a problem hiding this comment.
You can change the task from label to Textflow so that the text will not be concatenated and you can change the color of the text.
keiteo
reviewed
Oct 30, 2019
Comment on lines
+49
to
+76
| requireNonNull(model); | ||
| List<FlashCard> lastShownList = model.getFilteredFlashCardList(); | ||
| if (index.getZeroBased() >= lastShownList.size()) { | ||
| throw new CommandException(Messages.MESSAGE_INVALID_FLASHCARD_DISPLAYED_INDEX); | ||
| } | ||
|
|
||
| FlashCard badFlashcard = lastShownList.get(index.getZeroBased()); | ||
|
|
||
| Task task = new Task("To Do: Bad Questions"); | ||
| DueDate d = BadQuestions.getBadDeadline(); | ||
| Deadline deadline = new Deadline(task, d); | ||
|
|
||
| //TODO: add questions and due date into filtered bad flashcards list | ||
| Question q = badFlashcard.getQuestion(); | ||
|
|
||
| BadQuestions badQuestions = new BadQuestions(); | ||
|
|
||
| badQuestions.addBadQuestion(d, q); | ||
|
|
||
| badQuestions.saveAsJson(badQuestions); | ||
|
|
||
| try { | ||
| model.addDeadline(deadline); | ||
| } catch (DuplicateDeadlineException e) { | ||
| return new CommandResult(DUPLICATE_DEADLINE); | ||
| } | ||
|
|
||
| return new CommandResult(MESSAGE_SUCCESS); |
| @@ -0,0 +1,31 @@ | |||
| //@@author: dalsontws | |||
There was a problem hiding this comment.
Correct format is //@@author dalsontws
Comment on lines
66
to
70
| // convert java object to JSON format, | ||
| // and returned as JSON formatted string | ||
| String json = gson.toJson(badQuestions.getBadQuestionsList()); | ||
| try { | ||
| //write converted json data to a file |
There was a problem hiding this comment.
Writing a method to abstract these steps might be better than to explain it through comments
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'Bad' FlashCard as a Deadline on the list
Store 'Bad' FlashCards in Json
Add Tests for 'Bad' Command
Integrate 'Bad' Command with Edit and Add FlashCard Commands