- adds change theme feature #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiteo
reviewed
Oct 30, 2019
Comment on lines
+32
to
+52
| /* todo: gui version | ||
| System.out.println(Main.class.getResourceAsStream("/images/Light.png")); | ||
| Image light = new Image(Main.class.getResourceAsStream("/images/Light.png")); | ||
| Image dark = new Image(Main.class.getResourceAsStream("/images/Dark.png")); | ||
| System.out.println(light.getUrl()); | ||
| ImageView iv = new ImageView(); | ||
| AnchorPane an = new AnchorPane(); | ||
| an.getChildren().add(iv); | ||
| Scene scene = new Scene(an); | ||
| Scene scene = new Scene(new ThemeWindow().getView()); | ||
| Stage stage = new Stage(); | ||
| stage.setTitle("Theme"); | ||
| stage.show(); | ||
|
|
||
| GuiSettings guiSettings = model.getGuiSettings(); | ||
| GuiSettings newGuiSettings = new GuiSettings(guiSettings.getWindowWidth(), | ||
| guiSettings.getWindowHeight(), guiSettings.getWindowCoordinates().x, | ||
| guiSettings.getWindowCoordinates().y, styleSheet); | ||
| model.setGuiSettings(newGuiSettings); | ||
|
|
||
| */ |
There was a problem hiding this comment.
Remember to remove in the final release
Comment on lines
19
to
28
| if (trimedInput.equals("light")) { | ||
| color = "black"; | ||
| styleSheet = "view/LightTheme.css"; | ||
| } else if (trimedInput.equals("dark")) { | ||
| color = "white"; | ||
| styleSheet = "view/DarkTheme.css"; | ||
| } | ||
| if (styleSheet.isEmpty()) { | ||
| throw new ParseException(String.format(MESSAGE_INVALID_THEME)); | ||
| } |
There was a problem hiding this comment.
Consider rearranging the if conditions to handle exceptions first, and use else if for the 3rd one for slightly better readability
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
added a new light theme
added set theme command
theme light/theme dark/theme pinkrefresh GUI when setThemeCommand executes
minor changes to the dark theme