New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ugdg #153
Update ugdg #153
Conversation
docs/UserGuide.adoc
Outdated
@@ -366,7 +366,7 @@ Deletes a person with the NRIC S98654322D in ORGANice. | |||
=== Detecting matches: `match` | |||
|
|||
This command runs a kidney matching test on patients and donors in ORGANice and displays the match results. | |||
Refer to <<FAQ>> for a better understanding of the procedure for kidney matching. | |||
Refer to <<Glossary>> for a better understanding of the procedure for kidney matching. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FAQ seems correct here why change to Glossary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended.
docs/UserGuide.adoc
Outdated
@@ -562,6 +583,9 @@ that contains the data of your previous ORGANice folder. | |||
2. Do a tissue typing test to determine the HLA antigens of the patient and the donor. | |||
3. Do a cross match, which is a trial transfusion. | |||
|
|||
*Q*: What is the success rate and how is it computed? + | |||
*A*: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The success rate measures the tissue compatibility between a donor and a patient. It is computed via this formula: (number of common tissue types between donor and patient) / 6 * 100%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! I've suggested a change.
docs/UserGuide.adoc
Outdated
|
||
=== Sorting matches: `sort` | ||
Users can specify how they want the patient-donor pairs to be sorted. + | ||
Sorting is done by passing in optional parameters to the `match` command. + | ||
This section specifies how a list of matches can be sorted to determine which patient to prioritize for organ transplant. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better tone to sound as if you are talking with the user? Such as, After getting the list of potential donors, you can ........
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended.
docs/UserGuide.adoc
Outdated
|
||
Matches can be sorted according to three categories: | ||
**The sort command can only be used after a match command** to sort the resulting list of patient-donor pairs generated. | ||
The following specifies three categories by which you can sort the matches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect 3 bullet points if you said this, so can add in the 3 categories as bullet points her maybe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im quite confused on the Glossary
and FAQ
thingy, sometimes it get mixed up, then for the language use a more conversational tone and maybe can include screenshots to show the different orderings for each category. But good job!!
docs/UserGuide.adoc
Outdated
1. Success rate of match | ||
2. Priority of patient | ||
3. Date of expiry of donors' organs | ||
1. Sorting based on donor's organ expiry date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i prefer bullet points though cause order here doesnt matter. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
update model class diagram image
update ugdg for sorting feature