Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reminder UI + Storage #123

Merged
merged 31 commits into from
Oct 30, 2019
Merged

Reminder UI + Storage #123

merged 31 commits into from
Oct 30, 2019

Conversation

TSAI-HSIAO-HAN
Copy link

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN commented Oct 22, 2019 •
edited

  • Create Reminder UI
  • Create Reminder Edit, Delete Command(without Storage)
  • Refactor Reminder Structure(Change dependency)
  • Implement Storage
  • Add testing for Storage(do in V1.4)
    resolve Implement Reminder Commands with Storage #105

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN changed the title Reminder UI + Storage WIP: Reminder UI + Storage Oct 22, 2019
@dorcastan dorcastan added this to In progress in v1.3 via automation Oct 26, 2019
@dorcastan dorcastan added this to the v1.3 milestone Oct 26, 2019
@TSAI-HSIAO-HAN @Na-Nazhou
Apply suggestions from code review
39aafc4 
Co-Authored-By: Na Nazhou <42093424+Na-Nazhou@users.noreply.github.com>
Na-Nazhou
Na-Nazhou requested changes Oct 30, 2019
View reviewed changes
Copy link

@Na-Nazhou Na-Nazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just some minor issues

src/main/java/seedu/mark/logic/commands/EditReminderCommand.java Outdated Show resolved Hide resolved
src/main/java/seedu/mark/logic/commands/EditReminderCommand.java Outdated Show resolved Hide resolved
@TSAI-HSIAO-HAN @Na-Nazhou
Apply suggestions from code review
d6ff1c5 
Co-Authored-By: Na Nazhou <42093424+Na-Nazhou@users.noreply.github.com>
dorcastan
dorcastan previously approved these changes Oct 30, 2019
View reviewed changes
v1.3 automation moved this from Review in progress to Reviewer approved Oct 30, 2019
@TSAI-HSIAO-HAN TSAI-HSIAO-HAN merged commit 83158d0 into AY1920S1-CS2103T-T13-4:master Oct 30, 2019
v1.3 automation moved this from Reviewer approved to Done Oct 30, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 30, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Na-Nazhou Na-Nazhou Na-Nazhou approved these changes

@dorcastan dorcastan dorcastan left review comments

Assignees
No one assigned
Labels
PR: merged
Projects
No open projects
v1.3
  
Done
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

Implement Reminder Commands with Storage
3 participants
@TSAI-HSIAO-HAN @Na-Nazhou @dorcastan