Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG and edit UG #130

Conversation

TSAI-HSIAO-HAN
Copy link

No description provided.

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN changed the title update DG and edit UG WIP: update DG and edit UG Oct 23, 2019
@TSAI-HSIAO-HAN TSAI-HSIAO-HAN changed the title WIP: update DG and edit UG Update DG and edit UG Oct 23, 2019
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
Copy link
Author

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply suggestion.

TSAI-HSIAO-HAN and others added 2 commits October 23, 2019 20:13
Co-Authored-By: Na Nazhou <42093424+Na-Nazhou@users.noreply.github.com>
Co-Authored-By: Open O. Close <3646725+openorclose@users.noreply.github.com>
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
Co-Authored-By: Na Nazhou <42093424+Na-Nazhou@users.noreply.github.com>
Copy link
Author

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reply suggestion

docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
docs/DeveloperGuide.adoc Show resolved Hide resolved
docs/DeveloperGuide.adoc Outdated Show resolved Hide resolved
Co-Authored-By: Na Nazhou <42093424+Na-Nazhou@users.noreply.github.com>
Copy link

@kxyoke kxyoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can, we merge this first, then make any other changes subsequently

Copy link

@Na-Nazhou Na-Nazhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be okay for now I think. We can still make some amendments in future releases.

@TSAI-HSIAO-HAN TSAI-HSIAO-HAN merged commit 7bf1c38 into AY1920S1-CS2103T-T13-4:master Oct 23, 2019
@Na-Nazhou Na-Nazhou added this to the v1.3 milestone Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants