Refactor code to extend from Main #14
Conversation
| @@ -3,34 +3,34 @@ | |||
|
|
|||
| Actor User as user USER_COLOR | |||
| Participant ":UI" as ui UI_COLOR | |||
| Participant ":Logic" as logic LOGIC_COLOR | |||
| Participant ":Logic" as addressBookLogic LOGIC_COLOR | |||
There was a problem hiding this comment.
Good use of addressBookLogic to differentiate that this variable was previously from adress book
| @Override | ||
| Optional<AddressBookUserPrefs> readUserPrefs() throws DataConversionException, IOException; | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Possible to add java docs explaining what the new overridden method does
|
|
||
| /** | ||
| * Represents an error which occurs during execution of a {@link Command}. | ||
| * Represents an error which occurs during execution of a {@link seedu.main.logic.commands.Command}. |
There was a problem hiding this comment.
Good rewriting of the java docs comments to suit the current changes
| import seedu.address.model.AddressBook; | ||
| import seedu.address.testutil.TypicalPersons; | ||
| import seedu.main.commons.exceptions.IllegalValueException; |
There was a problem hiding this comment.
I don't think there is a need to shift down the imports. Since the imports are meant to be sorted by alphabetical order. Hence, the imports with common should be at the first 2 lines
|
Great Job refactoring! |
|
Implementation to refactor code was largely confusing. |
No description provided.