Enhancing LinWei's Paging construct #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhoohaha
reviewed
Oct 13, 2019
There was a problem hiding this comment.
Overall, implementation was clean and clear. Great work.
I would personally prefer the pages being non static and that the classes would need a pages object in order to call it, this would minimise instances where the List<Page> pages could be changed if you can have access to getPages() from anywhere if it is static simply by importing the class. But making it static is fine also!
I would also suggest that you create some test classes to increase testability. In addition, try to run checkStyleMain(), although we agreed to disable it but you wouldn't want to accumulate too much checkStyles to resolve.
Last but not least, ready to merge once you're ready (after passing Travis)!
src/main/java/seedu/address/financialtracker/ui/FinancialTrackerPage.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/financialtracker/commands/DeleteFinCommand.java
Outdated
Show resolved
Hide resolved
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apart from making my FinancialTrackerPage being able to switch between main and financial tracker page smoothly, I've also implemented ways to load FXML files easily. You guys can easily deal with SceneBuilder afterwards. With that being said, do look around and tell me if you think it's okay :P
Do check out my FinancialTrackerPage.java constructor