Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rewind command feature #105

Merged
merged 4 commits into from Oct 27, 2019
Merged

Implement rewind command feature #105

merged 4 commits into from Oct 27, 2019

Conversation

le0tan
Copy link

@le0tan le0tan commented Oct 24, 2019

Closes #83

@le0tan le0tan added this to the v1.3 milestone Oct 24, 2019
@le0tan le0tan requested a review from jiayushe October 24, 2019 07:38
@le0tan le0tan self-assigned this Oct 24, 2019
@le0tan le0tan added this to In progress in AlgoBase via automation Oct 24, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 254

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 176 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.05%) to 32.983%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/CommandResult.java 7 65.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/LogicManager.java 9 61.54%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/AlgoBaseParser.java 23 32.35%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/AlgoBase.java 24 52.24%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/CommandBox.java 25 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/MainWindow.java 36 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/ModelManager.java 52 37.5%
Totals Coverage Status
Change from base Build 250: 0.05%
Covered Lines: 1003
Relevant Lines: 3041
💛 - Coveralls

@le0tan le0tan requested review from tiuweehan and removed request for jiayushe October 25, 2019 06:53
jiayushe
jiayushe approved these changes Oct 27, 2019
View reviewed changes
Copy link

@jiayushe jiayushe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/java/seedu/algobase/ui/CommandBox.java
@@ -21,11 +25,34 @@
@FXML
private TextField commandTextField;


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line.

AlgoBase automation moved this from In progress to Reviewer approved Oct 27, 2019
Seris370
Seris370 approved these changes Oct 27, 2019
View reviewed changes
Copy link

@Seris370 Seris370 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@le0tan
Merge remote-tracking branch 'upstream/master' into recall
37d9fdd 
# Conflicts:
#	src/main/java/seedu/algobase/logic/parser/AlgoBaseParser.java
#	src/main/java/seedu/algobase/model/AlgoBase.java
#	src/main/java/seedu/algobase/model/Model.java
#	src/main/java/seedu/algobase/model/ModelManager.java
#	src/main/java/seedu/algobase/model/ReadOnlyAlgoBase.java
#	src/test/java/seedu/algobase/logic/commands/DefaultModelStub.java
@le0tan le0tan merged commit 84014ff into AY1920S1-CS2103T-W11-1:master Oct 27, 2019
AlgoBase automation moved this from Reviewer approved to Done Oct 27, 2019
@le0tan le0tan deleted the recall branch October 28, 2019 07:52
@nus-se-bot nus-se-bot mentioned this pull request Oct 29, 2019
Closed
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seris370 Seris370 Seris370 approved these changes

@tiuweehan tiuweehan tiuweehan approved these changes

@jiayushe jiayushe jiayushe approved these changes

@LuWenQ LuWenQ Awaiting requested review from LuWenQ

Assignees

@le0tan le0tan

Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a user, I want to find previous commands
5 participants
@le0tan @coveralls @Seris370 @tiuweehan @jiayushe