Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Task UIUX and Fix Bugs #143

Merged
merged 7 commits into from Oct 30, 2019
Merged

Update Task UIUX and Fix Bugs #143

merged 7 commits into from Oct 30, 2019

Conversation

jiayushe
Copy link

@jiayushe jiayushe commented Oct 30, 2019 •
edited

@jiayushe jiayushe added this to the v1.4 milestone Oct 30, 2019
@jiayushe jiayushe self-assigned this Oct 30, 2019
@jiayushe jiayushe added this to In progress in AlgoBase via automation Oct 30, 2019
@coveralls
Copy link

coveralls commented Oct 30, 2019 •
edited

Pull Request Test Coverage Report for Build 325

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 152 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.9%) to 34.084%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/TaskCard.java 7 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/AlgoBase.java 9 44.95%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/TaskManagementPane.java 12 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/plan/PlanList.java 18 33.33%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/AlgoBaseParser.java 28 25.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/plan/Plan.java 37 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/ModelManager.java 41 36.43%
Totals Coverage Status
Change from base Build 316: -0.9%
Covered Lines: 1498
Relevant Lines: 4395
💛 - Coveralls

le0tan
le0tan approved these changes Oct 30, 2019
View reviewed changes
Copy link

@le0tan le0tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However as you did some refactoring, not sure how RepoSense will register these changes (will it change the authorship for the commands?)

AlgoBase automation moved this from In progress to Reviewer approved Oct 30, 2019
@jiayushe jiayushe changed the title Update Task Style and Fix Bugs Update Task UIUX and Fix Bugs Oct 30, 2019
@jiayushe jiayushe merged commit 6fca19e into AY1920S1-CS2103T-W11-1:master Oct 30, 2019
AlgoBase automation moved this from Reviewer approved to Done Oct 30, 2019
This was referenced Oct 30, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le0tan le0tan le0tan approved these changes

Assignees

@jiayushe jiayushe

Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

No message returned while use command edittask No message returned while use command Donetask
3 participants
@jiayushe @coveralls @le0tan