Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation and Fix Bugs #236

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Update Documentation and Fix Bugs #236

merged 2 commits into from
Nov 9, 2019

Conversation

tiuweehan
Copy link

@tiuweehan tiuweehan commented Nov 9, 2019 •
edited
Loading

  • Update UG/DG/PPP
  • Refactor requireNonNull to be before logger
  • Fix missing // Fallthrough comment for Switch statements

@tiuweehan tiuweehan added this to the v1.4 milestone Nov 9, 2019
@tiuweehan tiuweehan requested a review from le0tan November 9, 2019 11:08
@tiuweehan tiuweehan self-assigned this Nov 9, 2019
@tiuweehan tiuweehan added this to In progress in AlgoBase via automation Nov 9, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 485

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 9 files lost coverage.
  • Overall coverage remained the same at 51.257%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/CloseDetailsTabUiActionParser.java 3 18.18%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/OpenDetailsTabUiActionParser.java 3 18.18%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/SetPlanUiActionParser.java 3 22.22%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/SwitchDetailsTabUiActionParser.java 3 22.22%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/SwitchDisplayTabUiActionParser.java 3 22.22%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/DeletePlanUiActionParser.java 4 22.22%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/DeleteProblemUiActionParser.java 4 18.18%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/EditPlanUiActionParser.java 10 7.69%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/ui/action/parser/EditProblemUiActionParser.java 13 5.0%
Totals Coverage Status
Change from base Build 484: 0.0%
Covered Lines: 2794
Relevant Lines: 5451
💛 - Coveralls

@tiuweehan tiuweehan changed the title Refactor Non-Null before logger Refactor requireNonNull before logger Nov 9, 2019
AlgoBase automation moved this from In progress to Reviewer approved Nov 9, 2019
@tiuweehan tiuweehan changed the title Refactor requireNonNull before logger Update Documentation and Fix Bugs Nov 9, 2019
@tiuweehan tiuweehan merged commit 15a0a6c into AY1920S1-CS2103T-W11-1:master Nov 9, 2019
AlgoBase automation moved this from Reviewer approved to Done Nov 9, 2019
This was referenced Nov 13, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le0tan le0tan le0tan approved these changes

@jiayushe jiayushe Awaiting requested review from jiayushe

@LuWenQ LuWenQ Awaiting requested review from LuWenQ

@Seris370 Seris370 Awaiting requested review from Seris370

Assignees

@tiuweehan tiuweehan

Labels
status.reviewRequired type.Bug A bug
Projects
AlgoBase
  
Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiuweehan @coveralls @le0tan