Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more explanation to DEFAULT constants #35

Merged
merged 1 commit into from
Sep 29, 2019
Merged

Add more explanation to DEFAULT constants #35

merged 1 commit into from
Sep 29, 2019

Conversation

le0tan
Copy link

@le0tan le0tan commented Sep 28, 2019

No description provided.

@le0tan le0tan added this to the v1.1 milestone Sep 28, 2019
@le0tan le0tan added this to In progress in AlgoBase via automation Sep 28, 2019
tiuweehan
tiuweehan approved these changes Sep 29, 2019
View reviewed changes
Copy link

@tiuweehan tiuweehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @Seris370 I think you can refer to how the default values are set here.

AlgoBase automation moved this from In progress to Reviewer approved Sep 29, 2019
@le0tan le0tan merged commit 90b0f91 into AY1920S1-CS2103T-W11-1:master Sep 29, 2019
AlgoBase automation moved this from Reviewer approved to Done Sep 29, 2019
@le0tan le0tan deleted the fix-codestyle branch September 29, 2019 08:56
@nus-se-bot nus-se-bot mentioned this pull request Oct 1, 2019
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiuweehan tiuweehan tiuweehan approved these changes

Assignees
No one assigned
Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@le0tan @tiuweehan @jiayushe