Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement find for name, description and author #64

Merged
merged 8 commits into from Oct 14, 2019
Merged

Implement find for name, description and author #64

merged 8 commits into from Oct 14, 2019

Conversation

le0tan
Copy link

@le0tan le0tan commented Oct 10, 2019

Closes #2 #4 #9

@le0tan le0tan added the status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. label Oct 10, 2019
@le0tan le0tan added this to the v1.2 milestone Oct 10, 2019
@le0tan le0tan self-assigned this Oct 10, 2019
@le0tan le0tan added this to In progress in AlgoBase via automation Oct 10, 2019
@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited

Pull Request Test Coverage Report for Build 149

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 112 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 39.837%
Files with Coverage Reduction New Missed Lines %
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/commons/util/CollectionUtil.java 1 77.78%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/model/problem/NameContainsKeywordsPredicate.java 2 76.92%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/parser/FindCommandParser.java 39 0.0%
file:/home/travis/build/AY1920S1-CS2103T-W11-1/main/src/main/java/seedu/algobase/logic/commands/FindCommand.java 70 0.0%
Totals Coverage Status
Change from base Build 145: 0.1%
Covered Lines: 829
Relevant Lines: 2081
💛 - Coveralls

@le0tan le0tan added status.reviewRequired and removed status.Ongoing The issue is currently being worked on. note: remove this label before closing an issue. labels Oct 11, 2019
AlgoBase automation moved this from In progress to Reviewer approved Oct 11, 2019
LuWenQ
LuWenQ previously approved these changes Oct 11, 2019
View reviewed changes
@le0tan le0tan requested a review from LuWenQ October 11, 2019 15:39
@le0tan le0tan mentioned this pull request Oct 13, 2019
Closed
9 tasks
@LuWenQ LuWenQ dismissed their stale review October 14, 2019 01:18

I need to take a closer look.

AlgoBase automation moved this from Reviewer approved to Review in progress Oct 14, 2019
@le0tan le0tan requested review from LuWenQ and jiayushe and removed request for tiuweehan October 14, 2019 06:10
tiuweehan
tiuweehan approved these changes Oct 14, 2019
View reviewed changes
src/main/java/seedu/algobase/logic/parser/FindCommandParser.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/parser/FindCommandParser.java Outdated Show resolved Hide resolved
src/main/java/seedu/algobase/model/problem/DifficultyIsInRangePredicate.java
@Override
public boolean test(Problem problem) {
Difficulty difficulty = problem.getDifficulty();
return difficulty.value >= lowerBound && difficulty.value <= upperBound;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could possible be abstracted to a separate method

src/main/java/seedu/algobase/model/problem/TagIncludesKeywordsPredicate.java Show resolved Hide resolved
src/main/java/seedu/algobase/logic/parser/FindCommandParser.java Outdated Show resolved Hide resolved
src/test/java/seedu/algobase/model/problem/NameContainsKeywordsPredicateTest.java Outdated Show resolved Hide resolved
AlgoBase automation moved this from Review in progress to Reviewer approved Oct 14, 2019
@le0tan le0tan merged commit 26ff510 into AY1920S1-CS2103T-W11-1:master Oct 14, 2019
AlgoBase automation moved this from Reviewer approved to Done Oct 14, 2019
@nus-se-bot nus-se-bot mentioned this pull request Oct 16, 2019
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiuweehan tiuweehan tiuweehan approved these changes

@LuWenQ LuWenQ LuWenQ left review comments

Assignees

@le0tan le0tan

Labels
status.reviewRequired
Projects
AlgoBase
  
Done
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

As a user, I want to be able to search by exact match
4 participants
@le0tan @coveralls @tiuweehan @LuWenQ